Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CRUD Index page to the new Admin Panel #15354

Conversation

jakubtobiasz
Copy link
Contributor

@jakubtobiasz jakubtobiasz commented Sep 23, 2023

Q A
Branch? bootstrap-admin-panel (2.0)
Bug fix? no
New feature?
BC breaks?
Deprecations?
Related tickets based on #15352
License MIT
CleanShot 2023-09-23 at 17 27 45@2x

CleanShot 2023-09-23 at 17 28 26@2x

@jakubtobiasz jakubtobiasz added Admin AdminBundle related issues and PRs. Frontend Issues and PRs related to frontend labels Sep 23, 2023
@jakubtobiasz jakubtobiasz requested a review from a team as a code owner September 23, 2023 15:28
@github-actions
Copy link

github-actions bot commented Sep 23, 2023

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

imports:
- { resource: 'template_events/*.yaml' }

sylius_ui:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Different names for syiius_ui bundle and template_events files will be a source of confusion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll unify that at some point, we'll go with ui events or template events as we have sylius_template_event and sylius_ui.events 🤷🏼‍♂️.

@@ -0,0 +1,19 @@
/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Random question, will bundles for 2.0 be converted to SF dir structure?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but we'll do it as one of the last tasks. Doing it right now will cause many conflicts while upmerging 1.13 -> 2.0.

@jakubtobiasz
Copy link
Contributor Author

Closed in favor of #15361

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin AdminBundle related issues and PRs. Frontend Issues and PRs related to frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants