Use Sylius State Machine Abstraction inside the Resource Controller State Machine #16051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bunnyshell Preview Environment deployment failedCheck https://github.com/Sylius/Sylius/actions/runs/8449003046 for details. Available commands:
|
jakubtobiasz
force-pushed
the
state-machine-resource-abstraction
branch
from
e158e07
to
eaee6bd
Compare
mpysiak
previously approved these changes
Mar 25, 2024
Wojdylak
previously approved these changes
Mar 26, 2024
src/Sylius/Bundle/CoreBundle/Resource/StateMachine/CompositeStateMachine.php
Outdated
Show resolved
Hide resolved
diimpp
reviewed
Mar 26, 2024
src/Sylius/Bundle/CoreBundle/DependencyInjection/Compiler/OverrideResourceStateMachinePass.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Resource/StateMachine/CompositeStateMachine.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Resource/StateMachine/CompositeStateMachine.php
Outdated
Show resolved
Hide resolved
jakubtobiasz
force-pushed
the
state-machine-resource-abstraction
branch
from
eaee6bd
to
c1c6188
Compare
jakubtobiasz
force-pushed
the
state-machine-resource-abstraction
branch
from
c1c6188
to
250638a
Compare
Wojdylak
approved these changes
Mar 27, 2024
|
Thank you, @jakubtobiasz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, despite we've been using new state machine abstraction everywhere, the Resource controllers have been still using the Resource Bundle abstraction. From now, everything goes through the abstraction.
P.S. I also let myself to remove setting the state machine to Symfony Workflow for all existing Sylius' graphs, as it could cause some BC issues.