Fix state machine tag #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zales0123
added
Bug
Zales0123
force-pushed
the
fix-state-machine-tag
branch
from
e7c6668
to
12a24c5
Compare
Zales0123
force-pushed
the
fix-state-machine-tag
branch
from
12a24c5
to
3b0e2e4
Compare
lchrusciel
approved these changes
May 14, 2024
|
Thank you, @Zales0123! |
|
Adding to the context, in Sylius/Sylius, the state machine from Resource is overridden to use abstraction (Sylius/Sylius#16051), so there is probably no need for any other changes here. Unless we would like to use the StateMachineAbstraction package here 馃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃憢 As Sylius introduced the state machine layer abstraction with its own
sylius.state_machineservice tag, we have a little conflict of configuration, which prevents using SyliusResourceBundle with Sylius 1.13 for now 馃拑 (see this issue)For now, I propose we change the tag in this repository to
sylius_resource.state_machine(which is also semantically more correct), but we should probably think if there is any thing we need to do on this repo according to this state machine abstraction 馃枛