Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] Footer #16210

Merged
merged 4 commits into from
Jun 17, 2024
Merged

[Admin] Footer #16210

merged 4 commits into from
Jun 17, 2024

Conversation

Rafikooo
Copy link
Contributor

@Rafikooo Rafikooo commented May 2, 2024

Q A
Branch? 2.0
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
License MIT
image

@Rafikooo Rafikooo requested review from a team as code owners May 2, 2024 16:48
@probot-autolabeler probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label May 2, 2024
Copy link

github-actions bot commented May 2, 2024

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

@Rafikooo Rafikooo force-pushed the footer branch 2 times, most recently from 354fe48 to 92d265a Compare May 6, 2024 12:38
@GSadee GSadee changed the base branch from bootstrap-admin-panel to 2.0 May 20, 2024 09:30
@GSadee
Copy link
Member

GSadee commented May 20, 2024

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "footer" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@@ -17,6 +17,9 @@ twig_hooks:
template: '@SyliusAdmin/shared/crud/create/content/form.html.twig'
configuration:
render_rest: true
footer:
template: '@SyliusAdmin/shared/crud/common/content/footer.html.twig'
priority: -100
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will add priorities to all the hooks at the end of the work on the BAP

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a problem with the layout in the following views. I wasn't able to set the footer at the bottom without using priorities.

image image

Comment on lines +16 to +40
<li class="list-inline-item">
<a href="https://docs.sylius.com" target="_blank" class="link-secondary" rel="noopener">
{{ 'sylius.ui.documentation'|trans }}
</a></li>
<li class="list-inline-item">
<a href="https://github.com/Sylius/Sylius?tab=MIT-1-ov-file#readme" target="_blank"
class="link-secondary" rel="noopener">
{{ 'sylius.ui.license'|trans }}
</a>
</li>
<li class="list-inline-item">
<a href="https://github.com/Sylius/Sylius" target="_blank" class="link-secondary"
rel="noopener">
{{ 'sylius.ui.source_code'|trans }}
</a>
</li>
<li class="list-inline-item">
<a href="https://github.com/Sylius/Sylius/issues" target="_blank" class="link-secondary"
rel="noopener">
{{ 'sylius.ui.see_issue'|trans }}? {{ 'sylius.ui.report_it'|trans }}!
</a>
</li>
<li class="list-inline-item">
{{ 'sylius.ui.powered_by'|trans }} Sylius v{{ sylius_meta.version }}.
</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it wouldn't be overengineered, but this place seems perfect to trigger another hook 🤔

@GSadee GSadee merged commit 3b6c07a into Sylius:2.0 Jun 17, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin AdminBundle related issues and PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants