Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin] Footer #16210

Merged
merged 4 commits into from
Jun 17, 2024
Merged

[Admin] Footer #16210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7bf319e
[Admin] Add footer template
Rafikooo May 2, 2024
758fde0
[Admin] Include footer hookable in default crud content hooks
Rafikooo May 2, 2024
9721597
[Admin] Include custom footer hookable in variant generation hook config
Rafikooo May 2, 2024
94b623e
[Admin] Set explicit priorities for footer hookable in default views …
Rafikooo May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Sylius/Bundle/AdminBundle/Resources/config/app/twig_hooks/common/create.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ twig_hooks:
template: '@SyliusAdmin/shared/crud/create/content/form.html.twig'
configuration:
render_rest: true
footer:
template: '@SyliusAdmin/shared/crud/common/content/footer.html.twig'
priority: -100
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will add priorities to all the hooks at the end of the work on the BAP

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a problem with the layout in the following views. I wasn't able to set the footer at the bottom without using priorities.

image image


'sylius_admin.common.create.content.header':
breadcrumbs:
Expand Down
3 changes: 3 additions & 0 deletions src/Sylius/Bundle/AdminBundle/Resources/config/app/twig_hooks/common/index.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ twig_hooks:
template: '@SyliusAdmin/shared/crud/common/content/header.html.twig'
grid:
template: '@SyliusAdmin/shared/crud/index/content/grid.html.twig'
footer:
template: '@SyliusAdmin/shared/crud/common/content/footer.html.twig'
priority: -100

'sylius_admin.common.index.content.header':
breadcrumbs:
Expand Down
3 changes: 3 additions & 0 deletions src/Sylius/Bundle/AdminBundle/Resources/config/app/twig_hooks/common/show.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ twig_hooks:
template: '@SyliusAdmin/shared/crud/common/content/flashes.html.twig'
header:
template: '@SyliusAdmin/shared/crud/common/content/header.html.twig'
footer:
template: '@SyliusAdmin/shared/crud/common/content/footer.html.twig'
priority: -100

'sylius_admin.common.show.content.header':
breadcrumbs:
Expand Down
3 changes: 3 additions & 0 deletions src/Sylius/Bundle/AdminBundle/Resources/config/app/twig_hooks/common/update.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ twig_hooks:
template: '@SyliusAdmin/shared/crud/update/content/form.html.twig'
configuration:
render_rest: true
footer:
template: '@SyliusAdmin/shared/crud/common/content/footer.html.twig'
priority: -100

'sylius_admin.common.update.content.header':
breadcrumbs:
Expand Down
2 changes: 2 additions & 0 deletions src/Sylius/Bundle/AdminBundle/Resources/config/app/twig_hooks/product/generate_variants.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ twig_hooks:
props:
resource: '@=_context.resource'
form: '@=_context.form'
footer:
template: '@SyliusAdmin/shared/crud/common/content/footer.html.twig'

'sylius_admin.product.generate_variants.content.header':
breadcrumbs:
Expand Down
45 changes: 45 additions & 0 deletions src/Sylius/Bundle/AdminBundle/templates/shared/crud/common/content/footer.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
<footer class="footer footer-transparent d-print-none">
<div class="container-xl">
<div class="row text-center align-items-center">
<div class="col-12 col-lg-12">
<ul class="list-inline list-inline-dots">
<li class="list-inline-item">
{{ 'sylius.ui.copyright'|trans }} © {{ 'now'|date("Y") }}
<a href="https://sylius.com/" target="_blank" class="link-secondary">Sylius</a>.
{{ 'sylius.ui.all_rights_reserved'|trans }}.
</li>
</ul>
</div>

<div class="col-lg-12 ms-lg-auto">
<ul class="list-inline list-inline-dots m-1">
<li class="list-inline-item">
<a href="https://docs.sylius.com" target="_blank" class="link-secondary" rel="noopener">
{{ 'sylius.ui.documentation'|trans }}
</a></li>
<li class="list-inline-item">
<a href="https://github.com/Sylius/Sylius?tab=MIT-1-ov-file#readme" target="_blank"
class="link-secondary" rel="noopener">
{{ 'sylius.ui.license'|trans }}
</a>
</li>
<li class="list-inline-item">
<a href="https://github.com/Sylius/Sylius" target="_blank" class="link-secondary"
rel="noopener">
{{ 'sylius.ui.source_code'|trans }}
</a>
</li>
<li class="list-inline-item">
<a href="https://github.com/Sylius/Sylius/issues" target="_blank" class="link-secondary"
rel="noopener">
{{ 'sylius.ui.see_issue'|trans }}? {{ 'sylius.ui.report_it'|trans }}!
</a>
</li>
<li class="list-inline-item">
{{ 'sylius.ui.powered_by'|trans }} Sylius v{{ sylius_meta.version }}.
</li>
Comment on lines +16 to +40
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it wouldn't be overengineered, but this place seems perfect to trigger another hook 🤔

</ul>
</div>
</div>
</div>
</footer>
4 changes: 4 additions & 0 deletions src/Sylius/Bundle/UiBundle/Resources/translations/messages.en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ sylius:
administration_panel_login: 'Administration panel login'
administration_reset_password: 'Administration reset password'
all: 'All'
all_rights_reserved: 'All rights reserved'
all_your_addresses: 'All your addresses'
amount: 'Amount'
an_error_occurred: 'An error occurred'
Expand Down Expand Up @@ -156,6 +157,7 @@ sylius:
contain_variants: 'Contain Variants'
contains: 'Contains'
content: 'Content'
copyright: 'Copyright'
countries: 'Countries'
country: 'Country'
country_code: 'Country code'
Expand Down Expand Up @@ -438,6 +440,7 @@ sylius:
latest_orders: 'Latest orders'
latest_products: 'Latest products'
less_than: 'Less than'
license: 'License'
links: 'Links'
list_coupons: 'List coupons'
list_variants: 'List variants'
Expand Down Expand Up @@ -821,6 +824,7 @@ sylius:
slug: 'Slug'
sort: 'Sort'
sort_by_date: 'Sort by date'
source_code: 'Source code'
source_currency: 'Source currency'
start_date: 'Start Date'
starts_at: 'Starts at'
Expand Down