[Security] Fixes for potential XSS in the Checkout, Address Book and Admin Panel #16241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…GSadee) This PR was merged into the 1.12 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.12 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | n/a | License | MIT Fixes CVE-2024-29376. Reported here: https://github.com/r2tunes/Reports/blob/main/Sylius.md Commits ------- 0a7fe9e Add js sanitizeInput function 89880cd Add sanitizer function to UIBundle 19cea9a Use function from UIBundle 3d66fb0 [AddressBook] Add scenario for preventing from a potential XSS attack 9255540 [Checkout] Add scenario for preventing from a potential XSS attack 30de6ff [Behat] Minor scenarios improvements after code review
This PR was merged into the 1.12 branch. Discussion ---------- | Q | A |-----------------|----- | Branch? | 1.12 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | n/a | License | MIT Fixes potential xss in admin panel (Taxons and Products) Commits ------- d4812f9 Fix potential xss in admin panel 29d18a3 Use function from UIBundle c11c424 Fix product-auto-complete a17de6d Test adding new taxon d25edf3 Test adding new simple product 63c3cf7 Test adding similar products 679e793 Fixes after CR
NoResponseMate
approved these changes
May 10, 2024
Wojdylak
approved these changes
May 10, 2024
mpysiak
approved these changes
May 10, 2024
TheMilek
approved these changes
May 10, 2024
|
Thank you, @GSadee! |
Bunnyshell Preview Environment deployment failedCheck https://github.com/Sylius/Sylius/actions/runs/9029035698 for details. Available commands:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to solve 2 issues: