Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User register in checkout on security step #69

Merged
merged 3 commits into from
May 14, 2013

Conversation

skowi
Copy link
Contributor

@skowi skowi commented May 14, 2013

Hi,

Here is PR with user registration during checkout. Big up to @pjedrzejewski for help :)

pjedrzejewski pushed a commit that referenced this pull request May 14, 2013
User register in checkout on security step
@pjedrzejewski pjedrzejewski merged commit cb715d6 into Sylius:master May 14, 2013
@pjedrzejewski
Copy link
Member

Thank you Szymon! 👍

@sargath
Copy link

sargath commented May 14, 2013

:) 👍

GSadee added a commit to GSadee/Sylius that referenced this pull request May 10, 2024
…GSadee)

This PR was merged into the 1.12 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.12
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | n/a
| License         | MIT

Fixes CVE-2024-29376. Reported here: https://github.com/r2tunes/Reports/blob/main/Sylius.md


Commits
-------

0a7fe9e Add js sanitizeInput function
89880cd Add sanitizer function to UIBundle
19cea9a Use function from UIBundle
3d66fb0 [AddressBook] Add scenario for preventing from a potential XSS attack
9255540 [Checkout] Add scenario for preventing from a potential XSS attack
30de6ff [Behat] Minor scenarios improvements after code review
TheMilek added a commit that referenced this pull request May 10, 2024
…ress Book and Admin Panel (GSadee)

This PR was merged into the 1.12 branch.

Discussion
----------

| Q               | A
|-----------------|-----
| Branch?         | 1.12
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | 
| License         | MIT

This PR aims to solve 2 issues:

- Potential Cross Site Scripting (XSS) via the "Province" field in the Checkout and Address Book (https://github.com/r2tunes/Reports/blob/main/Sylius.md)
- Potential Cross Site Scripting (XSS) via the "Name" field (Taxons, Products, Options, Variants) in the Admin Panel


Commits
-------
  Fix potential xss in admin panel
  Use function from UIBundle
  Fix product-auto-complete
  Add js sanitizeInput function
  Add sanitizer function to UIBundle
  Use function from UIBundle
  [AddressBook] Add scenario for preventing from a potential XSS attack
  [Checkout] Add scenario for preventing from a potential XSS attack
  [Behat] Minor scenarios improvements after code review
  Test adding new taxon
  Test adding new simple product
  Test adding similar products
  Fixes after CR
  bug #69 Fix potential xss in AdressBook and Checkout (mpysiak, GSadee)
  bug #76 Fix potential xss in admin panel (mpysiak)
  [Behat] Minor scenarios improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants