Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #1689 #1695

Merged
merged 1 commit into from
Sep 15, 2014
Merged

Fixed issue #1689 #1695

merged 1 commit into from
Sep 15, 2014

Conversation

umpirsky
Copy link
Contributor

@umpirsky umpirsky commented Jul 4, 2014

No description provided.

@pjedrzejewski
Copy link
Member

@umpirsky We use sylius_money for all values, I think the conversion should happen there. Thoughts?

@umpirsky
Copy link
Contributor Author

umpirsky commented Jul 4, 2014

@pjedrzejewski What class#line are you referring to?

@stloyd
Copy link
Contributor

stloyd commented Sep 3, 2014

@umpirsky @Arn0d @pjedrzejewski I think this is correct fix, problem with are located in Symfony transformers (used by sylius_money) that transform into float while in Sylius we hold data as integer.

So either we should force type to be integer or replace Doctrine type into float for prices, otherwise we will endup with annoying bug #1689 always logging price change. Personally I'm more with forcing integer instead of float.

ps. I was trying to find other way to fix this, but those two are simplest ones.

@stloyd
Copy link
Contributor

stloyd commented Sep 3, 2014

Additionally also OrderItem::setUnitPrice() should be changed same way as it's done in ProductVariant.

@umpirsky
Copy link
Contributor Author

@pjedrzejewski Let's merge this.

pjedrzejewski pushed a commit that referenced this pull request Sep 15, 2014
@pjedrzejewski pjedrzejewski merged commit da96366 into Sylius:master Sep 15, 2014
@pjedrzejewski
Copy link
Member

Thank you Sasha! 👍

@stloyd stloyd mentioned this pull request Sep 15, 2014
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants