-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promotions #17
Promotions #17
Conversation
Given I am logged in as administrator | ||
And the following promotion rules are defined: | ||
| type | configuration | | ||
| order_total | {"amount":5000, "equal":true} | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What {"amount":5000, "equal":true}
mean ? Will that promotion be included when order total amount will be equal 5000 ?
Maybe then we should use something like:
| type | amount | is_equal |
| order_total | 5000 | true |
instead of json ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is promotion rule configuration. Promotion actions will be applied only if rules are satisfied. In this case if order amount is greater then 5000.
But yes, I like the idea to use table instead of json, but then we must split this into 2 tables:
| type | amount | is_equal |
| order_total | 5000 | true |
and
| type | count | is_equal |
| item_count | 10 | true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, we should remove the json for sure. The case is that different rules can have many different parameters. So columns are not best option too... I think we could parse a simpler format like Amount: 500, Foo: bar
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pjedrzejewski Why not spliting and have table per rule/action, and add to config everything that is not type
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!
👍 👍 👍 |
Small cleanup of cart functionality, re-use existing collection code fro...
Made coordinator smarter
Add ::matchAll to ZoneMatcher & ZoneMatcherInterface
Removed inventory prefix
Init polish translation
[WIP] Symfony 2.3 upgrade
Small cleanup of cart functionality, re-use existing collection code fro...
Removed inventory prefix
Init polish translation
[WIP] Symfony 2.3 upgrade
Made coordinator smarter
Add ::matchAll to ZoneMatcher & ZoneMatcherInterface
…ntegration [CJMAX-18] Account order details page integration
Depends on;