Initial promotions implementation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| public function __construct($type) | ||
| { | ||
| parent::__construct(sprintf('Promotion action of type "%s" already exist.', $type)); |
There was a problem hiding this comment.
IMHO messages should not be hardcoded in exceptions...
There was a problem hiding this comment.
Translated? This exception is thrown if you try to register action via container tag, and name is taken. :) (in most cases)
Merged
|
YEAH! 👍 Nice work man! |
pjedrzejewski
pushed a commit
that referenced
this pull request
Feb 22, 2013
Initial promotions implementation
tleliberty
referenced
this pull request
in eliberty/SyliusPromotionBundle
Feb 20, 2018
Update ActionChoiceType.php
Zales0123
added a commit
that referenced
this pull request
Feb 4, 2022
Zales0123
added a commit
that referenced
this pull request
Jun 2, 2022
* 1.11: Specify explicit priorities for all form type extensions Small CS fixes Line length fixes PHP 8 syntax in bundles vol.2 Typehint templating engines properly Fix line length issues PHP 8 syntax in bundles #1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.