Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make PromotionEligibilityChecker easier to extend #1711

Merged
merged 1 commit into from
Jul 17, 2014
Merged

Make PromotionEligibilityChecker easier to extend #1711

merged 1 commit into from
Jul 17, 2014

Conversation

umpirsky
Copy link
Contributor

No description provided.

@sstok
Copy link
Contributor

sstok commented Jul 11, 2014

👍

@kayue
Copy link
Contributor

kayue commented Jul 12, 2014

👍

Maybe all method in CoreBundle should be protected?

@umpirsky
Copy link
Contributor Author

@kayue http://fabien.potencier.org/article/47/pragmatism-over-theory-protected-vs-private

pjedrzejewski pushed a commit that referenced this pull request Jul 17, 2014
Merge pull request #1711 from umpirsky/fix/extensiblePromotionEligibi…
74e792f 
…lityChecker

Make PromotionEligibilityChecker easier to extend
@pjedrzejewski pjedrzejewski merged commit 74e792f into Sylius:master Jul 17, 2014
@pjedrzejewski
Copy link
Member

Thanks Sasha!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@umpirsky @sstok @kayue @pjedrzejewski