[Core] Per-User usage limits on coupon #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
stloyd
force-pushed
the
feature/per_user_limit_coupons
branch
from
d5b7d18
to
7a0b374
Compare
stloyd
changed the title
stloyd
force-pushed
the
feature/per_user_limit_coupons
branch
from
7a0b374
to
c0041e8
Compare
This restricts users from placing multiple orders with the same discount. This is a commonly used feature in Magento for sites that have a max $ limit on their coupons. Users bypass this by placing multiple orders. Magento however doesn't force you to be logged in during the time of ordering, so it's easily bypassed that system.
stloyd
force-pushed
the
feature/per_user_limit_coupons
branch
from
c0041e8
to
dd257e5
Compare
|
@pjedrzejewski @Arn0d Can you review? Thanks! |
|
@pjedrzejewski @umpirsky Guys anything blocking this one? |
pjedrzejewski
pushed a commit
that referenced
this pull request
Sep 23, 2014
[Core] Per-User usage limits on coupon
|
Thank you @stloyd. |
| } | ||
| } | ||
| } else { | ||
| return false; |
There was a problem hiding this comment.
Exit sooner will be nice for ease readability/understanding
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
…pons [Core] Per-User usage limits on coupon
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
…pons [Core] Per-User usage limits on coupon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased & adjusted version of #920.