Added specs examples for overriding criteria and sorting parameters in route #1808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -251,6 +251,24 @@ function it_has_criteria_parameter(Parameters $parameters, Request $request) | |||
| $this->getCriteria()->shouldReturn($criteria); | |||
| } | |||
|
|
|||
| function it_allows_override_criteria_parameter_in_route(Parameters $parameters, Request $request) | |||
There was a problem hiding this comment.
it_allows_to_override sounds a bit better, what do you think? :)
|
Looks good to me, please tweak the example names and we should be good to merge. Thanks a lot @sivolobov! How do you like phpspec? :) |
|
@sivolobov 👍 Can you squash your commit and rebase it too? |
@Arn0d, It's done:-)
@pjedrzejewski, it is very convenient tool. I like it. I think that I will start my next project with BDD approach. But I think that PHPStorm needs a plugin which will be able to catch all the methods from object which for specs are. |
arnolanglade
added a commit
that referenced
this pull request
Aug 19, 2014
Added specs examples for overriding criteria and sorting parameters in route
|
@sivolobov Normally you should write spec before ;) thanks! |
|
@sivolobov ✌️ |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I do something wrong, please correct me.