Fix item based promotion issue #1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -79,6 +79,7 @@ protected function createUser($email, $password, $enabled = true, array $roles = | |||
| $user = $this->getUserRepository()->createNew(); | |||
| $user->setFirstname($this->faker->firstName); | |||
| $user->setLastname($this->faker->lastName); | |||
| $user->setUsername($email); | |||
umpirsky
force-pushed
the
fix/item-based-promotion-revert
branch
from
ec49888
to
2210154
Compare
|
@pjedrzejewski This should be ready, kindly review. |
|
ping @pjedrzejewski |
pjedrzejewski
pushed a commit
that referenced
this pull request
Sep 15, 2014
Fix item based promotion issue
| } catch (UnsupportedTypeException $exception) { | ||
| if (!$eligibleRules) { |
There was a problem hiding this comment.
What if the first rule throws an exception? This would set eligible to false prematurely. Perhaps we should do something that's more like the AuthorizationDecisionManager and rules could be more like voters. Then we could allow rules to abstain from certain votes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
Thanks for reporting it @kayue!