-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix behat context & fixtures after latest merges #1809
Conversation
@Arn0d @pjedrzejewski After #1803 Behat context & user fixtures are broken. |
The build still failed :) but 👍 |
d9922c2
to
775f826
Compare
@stloyd Do you know what happen for the feature "Users management" ? |
@Arn0d I'm trying to figure out that, but it seems that for Sylius we would need to revert part about |
$builder | ||
// Hide the username field | ||
->remove('username') | ||
->add('username', 'hidden') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we need to do this?
775f826
to
805c9ce
Compare
@pjedrzejewski @Arn0d Can you merge this? We can't fix this for Sylius in other way as we don't expose |
@pjedrzejewski I am for, what do you think? We need to find a way to fix travis (build exceeded more than 50minutes) |
Fix behat context & fixtures after latest merges
Thanks Joseph. |
👍 |
Fix behat context & fixtures after latest merges
No description provided.