Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behat context & fixtures after latest merges #1809

Merged
merged 1 commit into from
Aug 21, 2014

Conversation

stloyd
Copy link
Contributor

@stloyd stloyd commented Aug 20, 2014

No description provided.

@stloyd
Copy link
Contributor Author

stloyd commented Aug 20, 2014

@Arn0d @pjedrzejewski After #1803 Behat context & user fixtures are broken.

@arnolanglade
Copy link
Contributor

The build still failed :) but 👍

@arnolanglade
Copy link
Contributor

@stloyd Do you know what happen for the feature "Users management" ?

@stloyd
Copy link
Contributor Author

stloyd commented Aug 20, 2014

@Arn0d I'm trying to figure out that, but it seems that for Sylius we would need to revert part about setEmail() setting by default username... otherwise seems we need some "hacks" like overwriting user manager/provider services just to keep old "behavior".

$builder
// Hide the username field
->remove('username')
->add('username', 'hidden')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we need to do this?

@stloyd
Copy link
Contributor Author

stloyd commented Aug 21, 2014

@pjedrzejewski @Arn0d Can you merge this? We can't fix this for Sylius in other way as we don't expose username anywhere. This change is simplest way to fix the problem, others would be IMO too hacky (additional user manager/provider or form handler).

@arnolanglade
Copy link
Contributor

@pjedrzejewski I am for, what do you think? We need to find a way to fix travis (build exceeded more than 50minutes)

@stloyd
Copy link
Contributor Author

stloyd commented Aug 21, 2014

@Arn0d I guess the only possible way is something like #1814.

pjedrzejewski pushed a commit that referenced this pull request Aug 21, 2014
Fix behat context & fixtures after latest merges
@pjedrzejewski pjedrzejewski merged commit c4a677b into Sylius:master Aug 21, 2014
@pjedrzejewski
Copy link
Member

Thanks Joseph.

@arnolanglade
Copy link
Contributor

👍

@stloyd stloyd deleted the bugfix/broken_behat branch August 21, 2014 18:26
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
Fix behat context & fixtures after latest merges
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants