Mismatch between stripe transaction total and order total #1824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for catching this, I think we should use CurrencyConverter instead of templating helper. It is just matter of injecting different service here. Could you update the PR? :) |
|
Updated :) |
| /** | ||
| * @param CurrencyConverter $currencyConverter | ||
| */ | ||
| public function __construct(CurrencyConverter $currencyConverter) |
There was a problem hiding this comment.
We should use the interface here, not the implementation. :)
|
|
pjedrzejewski
pushed a commit
that referenced
this pull request
Aug 26, 2014
…ch-total Mismatch between stripe transaction total and order total
|
Haha, thanks Carl! 👍 |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When purchasing products using multiple currencies and the Stripe payment method, the total amount of the order within Stripe is always using the base currency amount.
e.g. If I buy a product which is £60 (and default currency is GBP), and I purchase it in Euros, the correct amounts are shown within Sylius (say 90 euros), however it seems that purchasing the product then using the Stripe payment method, the total amount sent to the Stripe API is calculated using the default currency. So Stripe will receive 60 Euros not 90.