[ResourceBundle] Automatic form registration

[Strontium-90]

Q	A
Bug fix?	[no]
New feature?	[yes]
BC breaks?	[no]
Deprecations?	[no]
Tests pass?	[yes]
Fixed tickets	[ #1384 ]
License	MIT
Doc PR	[]

Register resource form types as services.
Its possible register many form for resourse, i.e:

classes:
    controller: MyControllerClass
    form:
        default:             MyBundle\Form\Type\AnyResourceType
        short:                MyBundle\Form\Type\AnyResourceShortType
    choice_form:        MyBundle\Form\Type\AnyResourceChoiceType

[arnolanglade]

This should be reverted

[arnolanglade]

@Sylius/core-team What do you think about it ?

[Strontium-90]

Reworked and added specs.

[arnolanglade]

We supports PHP 5.3 :)

[arnolanglade]

@pjedrzejewski The functionality is very interesting, I would want it into the resource bundle!! @Strontium-90 Why do you merge #2012 into this PR? Can you revert it and squash your commit I will review it again.

[pjedrzejewski]

Looks really interesting, but please do what @Arn0d suggested, #2012 is a bit different thing, I'd like to evaluate them separately. Thanks and nice work! 👍

[stloyd]

This is useless as you assign this variable in switch later...

[Strontium-90]

You listed 1. and 1. but I pick the 2nd. 1. :)

@pjedrzejewski, @Arn0d, I reworked to this config, rebased... Any review and lets finish here?

[pjedrzejewski]

'choice' === $name.

[pjedrzejewski]

Awesome work Aleksey! Please tweak these few things I have mentioned + rebase and I will merge it. :) Thank you! 👍

[arnolanglade]

I had a quick look, it seems good!

[Strontium-90]

done

[pjedrzejewski]

Seems like there are still conflicts. :)

[Strontium-90]

Rebased again.

[pjedrzejewski]

Could you have a look why scenarios are failing? Master is green.

[Strontium-90]

Master is green.

Good news.

Almost green, but some suites exited with 137...

[pjedrzejewski]

Thank you so much Aleksey! This is a really cool thing, I will remove other forms. :) 👍

[Strontium-90]

I will remove other forms. :)

I think this will more easy, if we finish this PR #1921.

[adamelso]

This change is nice, I like it. However there's something slightly counter-intuitive in having to manipulate the service definitions just to pass in dependencies:

$container
    ->getDefinition('my.form.type.blog')
    ->setArguments(array(
        new Reference('my.repository.blog')
    ))
;

Perhaps in another PR, this can be exposed to the config?

[isometriks]

I agree with @adamelso, I think it would be easier to have a check to see if the form's definition already exists and if so, it doesn't create it. That way any form that isn't standard you can create in your service definitions and any simple ones will just get created by themselves. It seems silly to mess with the definitions programmatically only. Kind of adds a big learning curve for newer users and is harder to read and trace out errors. Should be simple to change it to this:

    protected function registerFormTypes(array $config, ContainerBuilder $container)
    {
        foreach ($config['classes'] as $model => $serviceClasses) {
            if (!isset($serviceClasses['form']) || !is_array($serviceClasses['form'])) {
                continue;
            }
            foreach ($serviceClasses['form'] as $name => $class) {
                $suffix = ($name === self::DEFAULT_KEY ? '' : sprintf('_%s', $name));
                $alias = sprintf('%s_%s%s', $this->applicationName, $model, $suffix);
                $definitionId = sprintf('%s.form.type.%s%s', $this->applicationName, $model, $suffix);

                // HERE
                if ($container->hasDefinition($definitionId)) {
                    continue;
                }

                $definition = new Definition($class);
                if ('choice' === $name) {
                    $definition->setArguments(array(
                        $serviceClasses['model'],
                        $config['driver'],
                        $alias
                    ));
                } else {
                    $definition->setArguments(array(
                        $serviceClasses['model'],
                        new Parameter(sprintf('%s.validation_group.%s%s', $this->applicationName, $model, $suffix))
                    ));
                }
                $definition->addTag('form.type',array('alias' => $alias));
                $container->setDefinition(
                    $definitionId,
                    $definition
                );
            }
        }
    }

[liverbool]

@isometriks I've use some your code snippet in my PR #2483 .