[BugFix][ContentBundle] Fix-1981 #1990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice catch @liverbool 👍 |
|
👍 |
|
@pjedrzejewski @Arn0d ping |
|
Thanks @liverbool |
|
Hi, Already fixed last week in my PR #1962 We should keep StaticContent name, because it's more generic and when we want (in near future) to put content in blocks (using CMF ContainerBlock), the Page name will be obsolete. May cause conflict while merging my PR (soon according @pjedrzejewski) |
|
Yes, I'd prefer to keep the StaticContentType naming... to be consistent with CMF and more generic, like @psyray said. That's why I have not merged this one right away... :) |
|
@pjedrzejewski ok, sorry ! This PR fix #1981 for now. #1962 will change the name again ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't know about status/process of ContentBundle but this's small bug fix.