Order user can be null #2017
Merged
Order user can be null #2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umpirsky
added a commit
to umpirsky/Sylius
that referenced
this pull request
Oct 14, 2014
| $details['HIDECLIENTEMAIL'] = 'yes'; | ||
| $details['CLIENTUSERAGENT'] = $this->httpRequest->headers->get('User-Agent', 'Unknown'); | ||
| $details['CLIENTIP'] = $this->httpRequest->getClientIp(); | ||
| $details['CLIENTIDENT'] = $order->getUser()->getId(); | ||
| $details['CLIENTIDENT'] = $order->getUser() ?: $order->getUser()->getId(); |
There was a problem hiding this comment.
This looks wrong, it should be probably:
$details['CLIENTIDENT'] = $order->getUser() ? $order->getUser()->getId() : $order->getEmail();
umpirsky
force-pushed
the
fix/issue-2017
branch
from
b745b6a
to
1ccfb6e
Compare
|
👍 |
|
@pjedrzejewski Please review and merge. |
|
@Arn0d Can you merge this bugfix? |
|
👍 |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #1816
order.usercan be null.So, all code like
$order->getUser()->should be fixed to support this change.For example https://github.com/Sylius/Sylius/blob/master/src/Sylius/Bundle/PayumBundle/Payum/Be2bill/Action/CapturePaymentUsingBe2billFormAction.php#L70.