Create new Storage component to reduce code duplication between components

[stloyd]

Next step after #2088.

[arnolanglade]

Insteresting! is some classes (like Sylius\Component\Storage\SessionStorage) are missing ?

[stloyd]

@Arn0d Not really: https://github.com/Sylius/Sylius/pull/2089/files#diff-30

[stloyd]

@pjedrzejewski I'm not sure I should also adjust Cart to have same approach as we have for Currency & Locale components...

[pjedrzejewski]

@stloyd Nice, I like it. Regarding cart, any reasons against?

[saidul]

Does it mean to allow storing cart id in cookie?

[stloyd]

@pjedrzejewski I guess that would be quite big BC break ;)
@saidul Yes, that was the point I had in mind.

[koemeet]

I think its a good idea to do the same with the Cart. See issue #2083. I think if you store it in a session or cookie, we could have this working, right?

[stloyd]

@steffenbrem Already pushed changes for Cart too.

[koemeet]

@stloyd Ah I see, great 👍 This is the best approach IMO.

[pjedrzejewski]

Thanks Joseph! 👍

[koemeet]

@pjedrzejewski This package is not available on packagist yet, this means we cannot install the resource-bundle etc. seperately. Even if I add the Storage repository to my composer.json, it won't install it. Does this PR has anything to do with it?

In the composer.json of the Storage component, it says its package name is: sylius/sequence?

[koemeet]

@stloyd @pjedrzejewski The cookie storage does not work correctly. I think because the cookie is only set on the request with $this->request->cookies->set($key, $value); and never on the response. So this is currently broken. I think you need a listener and add the cookie to the response later on, using: $response->headers->setCookie().

Also, in the storage key a dot (.) sign is used, which will be replaced by PHP. So even if the cookies did work, the keys would not match and the cart (or anyother stored thing) could not be fetched.