Remove hardcoded environment names where isDebug switch is good enough #2233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WebProfiler needs to be configured, so there can be env with debug = true, but no profiler. I mean custom env, what do you think? |
rtuin
force-pushed
the
feature/hardcoded-envs-to-isDebug
branch
from
3130688
to
a9bdddc
Compare
|
@pjedrzejewski Good thinking. Based on that, and looking at how it is defined in Symfony-stanard I think the environment specific bundles like WebProfiler should be moved back to the user's AppKernel. I've updated this PR accordingly. What do you think? |
|
Any further thoughts on this? I would like to see this fixed |
|
ping @pjedrzejewski |
|
All tests succeed now! |
pjedrzejewski
pushed a commit
that referenced
this pull request
Jan 16, 2015
Remove hardcoded environment names where isDebug switch is good enough
|
Thank you Richard! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into this being a problem since for local development I use the environment 'local'.
What do you think?