[ResourceBundle] The date type has been improved #2250
Conversation
arnolanglade
commented
Dec 13, 2014
arnolanglade
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
| */ | ||
| public function buildView(FormView $view, FormInterface $form, array $options) | ||
| { | ||
| if (array_key_exists('placeholder', $options) && 'none' == $options['placeholder']) { |
There was a problem hiding this comment.
I would use isset() as you don't allow null anyway, also you should call:
'none' === $options['placeholder']Same below.
arnolanglade
force-pushed
the
form-date
branch
2 times, most recently
from
7c18300
to
214ff63
Compare
arnolanglade
added
ResourceBundle
Enhancement
|
@Sylius/core-team What do you think ? |
|
@pjedrzejewski can you give me feedback plz? |
| $this->setDefaultOptions($resolver); | ||
| } | ||
|
|
||
| function it_should_have_collection_as_extended_type() |
|
Could you explain what exactly is going on here? :) |
|
It calculates the date format depending on the current locale when the date type is rendered as single text. The format format is rendered as placeholder and datepicker is enabled too. |
|
Sir @pjedrzejewski do you need more infos? |
|
ping @pjedrzejewski |
|
@pjedrzejewski pong :) what do we do? |
|
@pjedrzejewski Feedback? |
|
ping @pjedrzejewski |
|
@pjedrzejewski pong |
|
@pjedrzejewski ping |
arnolanglade
force-pushed
the
form-date
branch
from
214ff63
to
f3fc3b2
Compare
|
@pjedrzejewski rebase :) |
|
@pjedrzejewski I need it for a personal projet, do you want something like that? |
|
@pjedrzejewski ping |
|
@pjedrzejewski ping |
|
@pjedrzejewski pong! |
|
ping @pjedrzejewski |
[ResourceBundle] The date type has been improved
|
Thanks Arnaud! Sorry it took so long. 💃 |
|
✌️ no problem! |
[ResourceBundle] The date type has been improved
