Display variant image in cart #2336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if ($this->images->isEmpty()) { | ||
| $image = $this->getProduct()->getImage(); | ||
| } else { | ||
| $image = $this->images->first(); |
There was a problem hiding this comment.
I think you can just return here: return $this->images->first();. It will return null in case there is no image.
There was a problem hiding this comment.
Yep but I would miss the fallback to the product image. Do you prefer to move the fallback logic elsewhere?
There was a problem hiding this comment.
No, I mean just remove else clause and simply return, cause if the first condition is false, it will always return it anyway. :) Like this:
if ($this->images->isEmpty()) {
return $this->getProduct()->getImage();
}
return $this->images->first();There was a problem hiding this comment.
I didn't get you right ;) Thanks for feedback, this is fixed now.
…one found. Addresses issue #2332.
|
@pjedrzejewski @Arn0d Sounds good for me 👍 |
|
@pjedrzejewski Feedback? |
|
Any feedback on this @pjedrzejewski ? |
pjedrzejewski
pushed a commit
that referenced
this pull request
Jan 27, 2015
Display variant image in cart
|
Perfect, thank you Matthieu! 👍 |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
Display variant image in cart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to display variant image instead of product master variant image in cart. In case no variant image is available, it displays product master variant image.