fix attribute choice value #2679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge PR Sylius#2674 and Sylius#2675
This was referenced Apr 22, 2015
pjedrzejewski
pushed a commit
that referenced
this pull request
Apr 22, 2015
fix attribute choice value
|
Thank you Nicolas! 👍 |
|
Thanks for the merge @pjedrzejewski ... but I just realised there is something wrong with my PR. Let me know what you think about it and I can submit a new PR for it. |
|
I have created a new PR #2683 so you can check what I had in mind |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge PR #2674 and #2675