[ResourceBundle] Include sylius_resource classes in metadatalistener #2911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh :D 👍 |
|
👍 |
|
Build is green, I don't know what happened to Scrutinizer though. |
|
ping @pjedrzejewski |
|
@pjedrzejewski is there something wrong with this? |
|
ping @pjedrzejewski PR waiting for almost 2 months |
pjedrzejewski
pushed a commit
that referenced
this pull request
Aug 13, 2015
[ResourceBundle] Include sylius_resource classes in metadatalistener
|
@winzou Thank you Alexandre, for the PR and the ping. :D |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[ResourceBundle] Include sylius_resource classes in metadatalistener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using ResourceBundle standalone, the classes defined under
sylius_resource.resourcesconfig are not added to thesylius.config.classesparameter (cf SyliusResourceExtension.php#L49).But it is this parameter that is injected in the ORMMetadataListener, for assigning repository to their model in Doctrine for example (cf LoadORMMetadataSubscriber.php#L76).
This PR fixes this :)