[CoreBundle] Adding MailerListenerSpec, fixing CS, small refactor #3161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mgonyan
commented
Aug 20, 2015
mgonyan
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | enhancement |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets | no |
| License | MIT |
| Doc PR | no |
- Adding specs for OrderMailerListener class
- Refactoring conditions to send the email
| @@ -32,6 +30,9 @@ class MailerListener | |||
| */ | |||
| protected $emailSender; | |||
|
|
|||
| /** | |||
| * @param SenderInterface $emailSender | |||
| */ | |||
There was a problem hiding this comment.
You should remove it, attributes have already comment.
There was a problem hiding this comment.
sorry but, i don't see the issue to document the constructor. if the attributes have already a comment
pjedrzejewski
added
the
Enhancement
|
@pjedrzejewski could you please check the errors |
pjedrzejewski
pushed a commit
that referenced
this pull request
Aug 27, 2015
[CoreBundle] Adding MailerListenerSpec, fixing CS, small refactor
|
Scrutinizer errored and I can't retry the build. :( But Travis is OK, so I think we can merge it. Thank you! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.