[Inventory] Removed fluent interfaces #3296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Arminek
commented
Sep 17, 2015
Arminek
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Fixed tickets | no |
| License | MIT |
| * @return integer | ||
| */ | ||
| public function getOnHand(); | ||
|
|
||
| /** | ||
| * Set stock on hand. | ||
| * | ||
| * @param integer $onHand |
There was a problem hiding this comment.
int should be used to be consistent with Symfony.
michalmarcinkowski
added
the
Enhancement
Arminek
force-pushed
the
SYLIUS-76-inventory-component
branch
from
b1dc868
to
c15e619
Compare
michalmarcinkowski
added a commit
that referenced
this pull request
Sep 22, 2015
[Inventory] Removed fluent interfaces
|
Thank you Arek! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.