[Web][Form] - fixed unclickable upload buttons issue 3263 #3314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clickable areas on upload buttons, fixed by replacing <span> with <label for="id"> removed the fixed width in css that would also complicate translation strings change made also in image prototype html inside [Product] for consistency
…t to the upload button After choosing a file to upload, its name will be shown, next to the upload button to indicate what will be uploaded. Work with multiple file upload field also, but only when HTML5 Files API is supported (ie10+)
|
can anyone explain why is the test failing? |
|
@nakashu no fear, I'll take care of these bugs today :) |
|
bump for merge ? |
pjedrzejewski
pushed a commit
that referenced
this pull request
Sep 28, 2015
…ns_issue_3263 [Web][Form] - fixed unclickable upload buttons issue 3263
|
Thank you @nakashu! Great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
css/ hmtl changes
Styled upload button area is now fully clickable
Changes where also made in product image prototype html, for it to be consistent/working
Will also fix bugs with translated messages for upload button, as there is no need for the fixed width, that was present before
javascript - enhancement
Filename of file that would be uploaded is shown, next to upload button.
Works with multiple file upload fields also if browser supports HTML5 File API