[Metadata] Complete component & bundle integrated with Sylius Core #3350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pamil
commented
Sep 24, 2015
pamil
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets | #2307, #2358, #3128, #3134 |
| License | MIT |
| Doc PR | Sylius/Sylius-Docs#322 |
pamil
force-pushed
the
metadata-formulas
branch
from
96e336d
to
1ea4863
Compare
| @@ -18,7 +18,7 @@ | |||
| class MoneyHelper extends BaseMoneyHelper | |||
| { | |||
| /** | |||
| * @var LocaleContextInterface | |||
| * @var LocaleContextInterfaceP | |||
pamil
force-pushed
the
metadata-formulas
branch
from
1ea4863
to
b627cae
Compare
This was referenced Sep 24, 2015
3 tasks
pamil
force-pushed
the
metadata-formulas
branch
6 times, most recently
from
13acd94
to
ac74245
Compare
pamil
changed the title
pamil
force-pushed
the
metadata-formulas
branch
12 times, most recently
from
fb36ce2
to
5b4adeb
Compare
…lue, not reference
…lar dependency in CompositeMetadataRenderer
…path (added default value to get)
…r to MetadataHierarchyProvider
…y metadata subjects
pamil
force-pushed
the
metadata-formulas
branch
from
9817e10
to
1bb5508
Compare
pjedrzejewski
pushed a commit
that referenced
this pull request
Jan 26, 2016
[Metadata] Complete component & bundle integrated with Sylius Core
|
Great work Kamil! 👍 Quite a lot of new ideas for improvements but we will get there. :) @peteward With -27 lines this one should be BC-break-free. :D |
|
Yeah, I'd love to get rid of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.