Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UserBundle] Fix flash messages on UserController #3450

Merged
merged 4 commits into from
Oct 19, 2015
Merged

[UserBundle] Fix flash messages on UserController #3450

merged 4 commits into from
Oct 19, 2015

Conversation

gperdomor
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets -
License MIT
Doc PR -

Hi, this PR fix some issues when user change, request or reset password.

Now, two flash messages are shown, User has been successfully updated and another message depending of the action, this PR avoid the apparition of the first message and change some translations related to these actions.

@gperdomor
Copy link
Contributor Author

@pjedrzejewski @michalmarcinkowski please after review and merge this, please sync composer packages :D

pjedrzejewski pushed a commit that referenced this pull request Oct 19, 2015
[UserBundle] Fix flash messages on UserController
@pjedrzejewski pjedrzejewski merged commit 18c525b into Sylius:master Oct 19, 2015
@pjedrzejewski
Copy link
Member

Looks good to me, thank you @gperdomor!

@gperdomor gperdomor deleted the feature/user-flashes-fix branch December 17, 2015 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants