[Addressing] Country fixes #3507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure __toString() won't break on Country
|
I'm just curious, what countries codes can't be translated to localised country name by |
|
('BV', 'QU', 'HM', 'AN', 'QO', 'CS') They were in my Sylius DB from a long time ago |
pjedrzejewski
pushed a commit
that referenced
this pull request
Oct 30, 2015
[Addressing] Country fixes
|
Interesting, we should investigate this more and provide better output if possible, but this is definitely a needed fix, thank you Peter! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provinces for a country ordered by name by default
Ensure __toString() won't break on Country. I may have an old DB, but some countries in my db couldn't retrieve a translation so blew up when used in a country dropdown.