[Cart] Fixed and polished CartProviderSpec on PHP7 #3651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjedrzejewski
pushed a commit
that referenced
this pull request
Nov 30, 2015
[Cart] Fixed and polished CartProviderSpec on PHP7
|
Thank you Kamil! I think we should bring PHP7 back to the required builds. Wdyt? |
|
We may go for it since PHP7 builds are passing :) I'll prepare a PR for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build was failing on PHP7 due to doubled
$cartin methods definitions.Fixed formatting, renamed
$contextto$cartContext, changed order in specification methods to be the same as inlet.