Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Administration panel redesign with Bootstrap 3 #368

Merged
merged 33 commits into from
Oct 10, 2013
Merged

Conversation

pjedrzejewski
Copy link
Member

It requires a lot of work and clean up of css (or maybe moving everything to less), but it's a good start.

Before...

zaznaczenie_015
zaznaczenie_014
zaznaczenie_013

After...

zaznaczenie_012
zaznaczenie_011
zaznaczenie_009
zaznaczenie_010
zaznaczenie_008

@stloyd
Copy link
Contributor

stloyd commented Oct 3, 2013

❤️

Some conflicts with master I see =)

@pjedrzejewski
Copy link
Member Author

Ye ye I will rebase. And it's responsive, the left side menu is hidden on smaller devices, it appears as the standard bootstrap responsive menu on top navbar. It has quite a lot of small glitches on mobile, needs some fixing.

@stloyd
Copy link
Contributor

stloyd commented Oct 3, 2013

Do you need some help with that? I have some time and I love CSS =D

@pjedrzejewski
Copy link
Member Author

@stloyd Sure, just fork it. :)

@pjedrzejewski
Copy link
Member Author

Rebased!

@kayue
Copy link
Contributor

kayue commented Oct 3, 2013

We can remove the button shadow, doesn't have to look 3d I think.
Some buttons like the delete button is too standout but won't be use too often.

@kayue
Copy link
Contributor

kayue commented Oct 3, 2013

BTW I like TradeGecko's backend quite a lot

screen shot 2013-10-03 at 5 06 37 pm

@tristanbes
Copy link
Contributor

Classy !

@jjanvier
Copy link
Contributor

jjanvier commented Oct 3, 2013

<3

@arnolanglade
Copy link
Contributor

@pjedrzejewski : very good !!!

@stloyd
Copy link
Contributor

stloyd commented Oct 3, 2013

@pjedrzejewski Maybe add todo list what's missing etc. (in PR description or as a comment)?

@umpirsky
Copy link
Contributor

umpirsky commented Oct 3, 2013

Wow, great job!

@pjedrzejewski
Copy link
Member Author

@stloyd Will do. :)

@stloyd
Copy link
Contributor

stloyd commented Oct 3, 2013

@pjedrzejewski Can't push to main repo, and don't want to create new PR (you have pushed code to main not to fork so GH is a bit crappy here), so here you will find mine change (WIP): https://github.com/stloyd/Sylius/tree/bootstrap-3

@pjedrzejewski
Copy link
Member Author

I'll simply pull your changes to this PR. Thanks!

@Richtermeister
Copy link
Contributor

Very cool! +1 for less!

@winzou
Copy link
Contributor

winzou commented Oct 4, 2013

This is great! 👍
Please make the text of buttons details, edit and delete disappear on mobile, it takes too much place ;)

@stloyd
Copy link
Contributor

stloyd commented Oct 4, 2013

@pjedrzejewski Additional cleanup commit: 6d3bc99ffbf18b33da2af996b8d3c7ffe68c0160

@pjedrzejewski
Copy link
Member Author

@stloyd Dude, help me making the sidebar height: 100%, because it drives me crazy. Either I am a complete CSS noob or I can't handle Bootstrap styles properly. :D (Try on countries list, you get a quite long page)

@pjedrzejewski
Copy link
Member Author

@kayue I've removed the shadow from buttons, as you suggested!

@pjedrzejewski
Copy link
Member Author

@winzou Good idea, I'll look into this.

@smoench
Copy link

smoench commented Oct 6, 2013

+100 for less (or sccs) ;-) So we could easily customising the color/font theme via variables

@stloyd
Copy link
Contributor

stloyd commented Oct 7, 2013

@pjedrzejewski Here you have some fixes: 5c0bceb & 80c9357 (I'm looking now at sidebar).

@stloyd
Copy link
Contributor

stloyd commented Oct 7, 2013

With latest commits on my fork you can see:

fullpage
fullpage_med

@jjanvier
Copy link
Contributor

jjanvier commented Oct 7, 2013

that's cool ! @stloyd can the variants be collapsed ?

@amenophis
Copy link
Contributor

@stloyd @pjedrzejewski Great work on the backend design 👍

@stloyd
Copy link
Contributor

stloyd commented Oct 7, 2013

@jjanvier I was thinking on something like this, as well as about i.e. smaller dates (just 2013.08.13 23:06 instead September 13, 2013 23:06), less text on descriptions etc. but this would probably require to render both (that's why I'm not sure it's good way to go) in template and just show/hide basing on device size.

Also collapsing by default is not best idea IMO. But let's see what @pjedrzejewski thinks about that.

@molchanoviv
Copy link

@stloyd Looks great.

@stloyd
Copy link
Contributor

stloyd commented Oct 7, 2013

@jjanvier @pjedrzejewski Quick change so it's not perfect but works:
hide_variants

@stloyd
Copy link
Contributor

stloyd commented Oct 10, 2013

Few additional fixes on the way.

  1. Filter forms: df6a5797734777f627451cc02fbccf726a776601
  2. Hardcoded styles: 7a3d1059b35fb3e110289fa5f8b3dd240e37e616

@stloyd
Copy link
Contributor

stloyd commented Oct 10, 2013

@pjedrzejewski That gallery script is not compatible with Bootstrap 3 (at least it looks like that), maybe we should replace it with something simpler?

@pjedrzejewski
Copy link
Member Author

@stloyd Yes. http://fancybox.net/, what do you think? I couldn't find anything for BS3.

@pjedrzejewski
Copy link
Member Author

There is http://bootply.com/71401 and http://ashleydw.github.io/lightbox/ (better imo).

@stloyd
Copy link
Contributor

stloyd commented Oct 10, 2013

I guess that lightbox could be good as it's small, but if we want something more advanced I found this: http://blueimp.github.io/Gallery/

@snc
Copy link
Contributor

snc commented Oct 10, 2013

@pjedrzejewski
Copy link
Member Author

Hello Henrik! Thanks for suggestions guys, I like http://blueimp.github.io/Gallery/, @stloyd do you have a moment for this or should I work on it?

@stloyd
Copy link
Contributor

stloyd commented Oct 10, 2013

@pjedrzejewski Here you go: 8941ef37f15bf1c1a7f2e9a7922678898c656ef3

pjedrzejewski pushed a commit that referenced this pull request Oct 10, 2013
Administration panel redesign with Bootstrap 3
@pjedrzejewski pjedrzejewski merged commit d75d767 into master Oct 10, 2013
@pjedrzejewski
Copy link
Member Author

We'll address the minor issues in other PR's. Thanks @stloyd for help!

@pjedrzejewski
Copy link
Member Author

I also upgraded frontend to use Bootstrap3, without any major changes to the look though.

@jjanvier
Copy link
Contributor

Woha ! That's really beautiful !!

@winzou
Copy link
Contributor

winzou commented Oct 11, 2013

I have to say it: awesome work guys!

Two things though:

  • I could access to /administration/dashboard with basic user login. But when I wanted to go to /administration/orders I had to login into the administration login. Problem is: why did I have access to the dashboard without an administration login?
  • Images are throwing error 500 on demo.sylius.org
  • I don't know if this is done on purpose, but I don't like all those caps.

@molchanoviv
Copy link

Congratulations guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.