[ResourceBundle] check translations are possible before configuration them #3749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendavies
force-pushed
the
check-translations
branch
from
7cf8484
to
ba0c250
Compare
|
just noticed this is related to #3748 |
|
I thinks it's not comprehensive fix as you said
It still can't disable translation per resource. |
|
yes there are 2 issues here.
I've updated the PR |
bendavies
force-pushed
the
check-translations
branch
from
cce3ce2
to
86cf221
Compare
pjedrzejewski
pushed a commit
that referenced
this pull request
Dec 18, 2015
[ResourceBundle] check translations are possible before configuration them
|
Sounds good until we figure out what to do with coupling. :) Thank you very much Ben! 👍 |
|
thanks @pjedrzejewski |
|
@bendavies Let me know what do you think in #3750. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not using translations in my application, and an error is thrown here as I've not configured translations for my resources.
This was introduced by #3721.
Also, it seems it is not not possible to disable translations per resource, see here.