Merge Translation & TranslationBundle into Resource?

[pjedrzejewski]

Hey folks!

I would like to propose merging Translation and TranslationBundle into Resource and ResourceBundle respectively.

Caveats:

• You will still be able to creates resources which are not translatable. Just implement TranslatableInterface or not and configure translation node or not.

Rationale:

Pros:

• Removes overhead of having 4 packages instead of 2;
• Removes overhead of decoupling configuration and its processing in ResourceBundle;
• We can use TranslatableInterface and other interfaces safely everywhere to check if something supports translations, now we need to use string and check if bundle exists etc. - really annoying;
• Translation & TranslationBundle without ResourceBundle do not make much sense, is anyone actually using them without Resource?

Cons:

• I don't see any right now, but opening this RFC to find out. :)

I know that in perfect scenario we create an extensions system for ResourceBundle and every extension could add its own configuration node to every resource and also process metadata in its own way etc. and I'd love to do that but at this point we don't have time and I really don't see a reason to have it decoupled. It only adds overhead.

If someone thinks of using Translation from Sylius standalone, there are already bundles/components which have similar level of functionality.

[pjedrzejewski]

Ref. #3748 and #3721.

[gperdomor]

👍

[bendavies]

+1 sounds good.
sort of related, there is a lot of duplication of the configuration tree structures at the moment. I wonder if they can be made more DRY?