[Attribute] Update *AttributeByName => *AttributeByCode inline with updated model #3807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as name is now translated so this no longer makes sense
|
Definitely, thanks Peter! 👍 |
| { | ||
| foreach ($this->attributes as $attribute) { | ||
| if ($attribute->getName() === $attributeName) { | ||
| if ($attribute->getAttribute()->getCode() === $attributeCode) { |
There was a problem hiding this comment.
This $attribute should be renamed to $attributeValue because it looks weird :)
Btw. not sure why $this->attributes isn't $this->attributesValues...
There was a problem hiding this comment.
definitely agreed, but this isn't the subject of this PR. one for the future.
pjedrzejewski
pushed a commit
that referenced
this pull request
Jan 5, 2016
[Attribute] Update *AttributeByName => *AttributeByCode inline with updated model
|
Thanks Peter! |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[Attribute] Update *AttributeByName => *AttributeByCode inline with updated model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nameis now translated so this no longer makes sense