[AttributeBundle] Fix bug with the attribute value form subscriber #3825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pjedrzejewski
commented
Jan 7, 2016
pjedrzejewski
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets | #3798 |
| License | MIT |
| Doc PR | - |
| @@ -34,6 +34,7 @@ public function buildForm(FormBuilderInterface $builder, array $options) | |||
| ->add('attributes', 'collection', array( | |||
| 'required' => false, | |||
| 'type' => 'sylius_product_attribute_value', | |||
| 'prototype' => false, | |||
There was a problem hiding this comment.
I think array should be whole aligned or not aligned... Did we agree that aligning "arrows" is cheesy or not? 😄
There was a problem hiding this comment.
I did not want to introduce bigger diff than needed, but yeah, I can adjust that.
|
@pjedrzejewski unfortunately the build is failing... |
Also "wait" fix for time-to-time failing attributes scenario.
pjedrzejewski
force-pushed
the
attribute-bugs
branch
from
540a6cd
to
60b43a1
Compare
- slightly change adding attributes to product - written additional scenario for adding multiple attributes - added some waits to prevent errors
[Attribute] Final fixes in attribute scenarios
michalmarcinkowski
added a commit
that referenced
this pull request
Jan 8, 2016
[AttributeBundle] Fix bug with the attribute value form subscriber
|
Finally! Great job guys! 👍 |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[AttributeBundle] Fix bug with the attribute value form subscriber
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[AttributeBundle] Fix bug with the attribute value form subscriber
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.