[Attribute] Fix decoupling issues in AttributeBundle #3933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Zales0123
commented
Jan 20, 2016
Zales0123
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets | |
| License | MIT |
| Doc PR |
| $forms = array(); | ||
|
|
||
| $choices = ($request->query->has('sylius_product_attribute_choice')) ? $request->query->get('sylius_product_attribute_choice') : array(); | ||
| $choices = ($request->query->has(sprintf('sylius_%s_choice', $this->config->getResourceName()))) ? $request->query->get(sprintf('sylius_%s_choice', $this->config->getResourceName())) : array(); |
There was a problem hiding this comment.
micro-optimization but you could set the string before using it twice (it will make the line shorter too).
There was a problem hiding this comment.
ParameterBag::get() second argument is the default value, we can make it a lot simplier:
$config = $request->query->get(sprintf('sylius_%s_choice', $this->config->getResourceName()), []);
|
nice 👍 |
|
@Zales0123 Please apply this one comment and this is good to go, nice work! |
|
@pjedrzejewski Done ;) |
|
@pjedrzejewski OK, almost done, sth is wrong with Scrutinizer, it should be restarted... |
pjedrzejewski
pushed a commit
that referenced
this pull request
Jan 21, 2016
[Attribute] Fix decoupling issues in AttributeBundle
|
👍 |
Tetragramat
pushed a commit
to ThreeSixtyEu/Sylius
that referenced
this pull request
Feb 2, 2016
validace a zpracovani formularu, refs Sylius#3933
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.