Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cart][Behat] Properly rounded taxes on order #4041

Conversation

Zales0123
Copy link
Member

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets
License MIT
Doc PR

Added scenario that ensures proper taxes on order and order item units.

@pjedrzejewski pjedrzejewski added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Feb 2, 2016

Scenario: Properly rounded taxes for multiple products
When I add 1000 products "PHP T-Shirt" to the cart
Then my cart total should be "€12,546.00"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For customer the precision should be = 2...

@Zales0123 Zales0123 force-pushed the order-units-taxes-calculation-scenarios branch from a2dc463 to 77240b3 Compare February 3, 2016 08:43
And product "Symfony Mug" belongs to "Mugs" tax category
And product "PHP Mug" belongs to "Mugs" tax category
And store ships everything for free
And store allows paying offline
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we don't need the two steps above

michalmarcinkowski added a commit that referenced this pull request Feb 5, 2016
…-scenarios

[Cart][Behat] Properly rounded taxes on order
@michalmarcinkowski michalmarcinkowski merged commit 2f93404 into Sylius:master Feb 5, 2016
@michalmarcinkowski
Copy link
Contributor

👍

@Zales0123 Zales0123 deleted the order-units-taxes-calculation-scenarios branch October 28, 2016 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants