[Fixture] Quick fixes for channel not found bug #4095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good job! 👍 |
|
Good to go when green. |
michalmarcinkowski
added a commit
that referenced
this pull request
Feb 10, 2016
[Fixture] Quick fixes for channel not found bug
|
Thanks Mateusz! |
|
During review I noticed another issue, reported in #4097. |
|
@pjedrzejewski good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After last updates, problem with fixtures occurred, with
ChannelNotFoundException. There were two sources of this evil:OrderChannelListenerwhich got channel fromChannelContext(which led to exception) and set it on orderPromotionProcessorwhich found active promotions by channel (the same case as above)Quick fixes for these problems are:
OrderinOrderChannelListeneronly if it is not set yet (we're setting channel on each order inLoadOrdersDatafindActiveByChannelrepository method, rather than this fromChannelContextOf course, these are a little bit workarounds, but fortunately there is huge checkout and promotion's refactoring upcoming, which should kill these nasty bugs forever ;)