-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Rename SalesBundle to OrderBundle #410
Conversation
I added repository, the subtree-split part is on me. Only thing left is the docs PR. Thanks Julien! 👍 |
@pjedrzejewski I'll rebase when you'll be ready to merge this. |
@jjanvier Please rebase. :) |
@pjedrzejewski done |
@jjanvier You need to change this: https://github.com/Sylius/Sylius/blob/master/src/Sylius/Bundle/CoreBundle/DependencyInjection/SyliusCoreExtension.php#L82 otherwise it will not work. |
A few PR have been merged after this one. And a few references to SalesBundle still exist. I'll correct this after lunch ;) |
@stloyd @pjedrzejewski it should be ok now. I've fixed the glitches and squashed last ugly commits. |
@jjanvier Can you rebase? So I can merge it! Thanks =) |
@stloyd done, but let's wait for Travis ;) |
@stloyd greeeeeeeen |
[WIP] Rename SalesBundle to OrderBundle
Merged! But tree-split will be available when @pjedrzejewski turn back from Symfony Camp UA =) |
Update storage.rst
To fix #378
Is there something else to do ? Maybe something about the subtree split ?
Except documentation of course