Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Rename SalesBundle to OrderBundle #410

Merged
merged 2 commits into from
Oct 26, 2013
Merged

[WIP] Rename SalesBundle to OrderBundle #410

merged 2 commits into from
Oct 26, 2013

Conversation

jjanvier
Copy link
Contributor

To fix #378

Is there something else to do ? Maybe something about the subtree split ?
Except documentation of course

@pjedrzejewski
Copy link
Member

I added repository, the subtree-split part is on me. Only thing left is the docs PR. Thanks Julien! 👍

@jjanvier
Copy link
Contributor Author

@pjedrzejewski I'll rebase when you'll be ready to merge this.

@pjedrzejewski
Copy link
Member

@jjanvier Please rebase. :)

@jjanvier
Copy link
Contributor Author

@pjedrzejewski done

@stloyd
Copy link
Contributor

stloyd commented Oct 18, 2013

@jjanvier
Copy link
Contributor Author

A few PR have been merged after this one. And a few references to SalesBundle still exist. I'll correct this after lunch ;)

@jjanvier
Copy link
Contributor Author

@stloyd @pjedrzejewski it should be ok now. I've fixed the glitches and squashed last ugly commits.

@stloyd
Copy link
Contributor

stloyd commented Oct 26, 2013

@jjanvier Can you rebase? So I can merge it! Thanks =)

@jjanvier
Copy link
Contributor Author

@stloyd done, but let's wait for Travis ;)

@jjanvier
Copy link
Contributor Author

@stloyd greeeeeeeen

stloyd added a commit that referenced this pull request Oct 26, 2013
[WIP] Rename SalesBundle to OrderBundle
@stloyd stloyd merged commit 2ca401c into Sylius:master Oct 26, 2013
@stloyd
Copy link
Contributor

stloyd commented Oct 26, 2013

Merged! But tree-split will be available when @pjedrzejewski turn back from Symfony Camp UA =)

@jjanvier jjanvier deleted the feature/order-bundle branch October 26, 2013 19:11
pamil pushed a commit to pamil/Sylius that referenced this pull request Mar 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renaming SyliusSalesBundle to SyliusOrderBundle?
3 participants