[Theme] Context interface cleanup #4156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contexts ultimately should have only get* method. :) 👍 |
pjedrzejewski
added
Enhancement
pamil
force-pushed
the
theme-bundle-context-cleanup
branch
from
31f48d0
to
8ff53d1
Compare
pjedrzejewski
pushed a commit
that referenced
this pull request
Feb 16, 2016
[Theme] Context interface cleanup
|
Thanks Kamil! |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[Theme] Context interface cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ThemeContextInterface::getThemeHierarchy()proxy/helper methodThemeContextInterface::setTheme(ThemeInterface $theme)method as it does not apply to all theme contexts out thereThemeContextInterfacehas only agetTheme()method now, which will be a lot easier to implement and maintain.