[Core] [Theme] Integration with Sylius platform #4000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamil
force-pushed
the
theme-bundle-integration
branch
from
02470f3
to
4bb9a49
Compare
|
|
||
| Scenario: Unsetting a channel theme | ||
| When I unset "France" channel theme | ||
| Then any theme should not be used |
There was a problem hiding this comment.
Then none of the themes should be used?
pamil
force-pushed
the
theme-bundle-integration
branch
from
4bb9a49
to
49aa3a6
Compare
| Then that theme should be used | ||
|
|
||
| Scenario: Unsetting a channel theme | ||
| When I unset "France" channel theme |
There was a problem hiding this comment.
Missing Given I set theme...
pamil
force-pushed
the
theme-bundle-integration
branch
from
49aa3a6
to
6d4127f
Compare
| When I set "Maverick Meerkat" theme to be used by "France" channel | ||
| And I set "Vivid Vervet" theme to be used by "Poland" channel | ||
| Then "France" channel should use "Maverick Meerkat" theme | ||
| And "Poland" channel should use "Vivid Vervet" theme |
There was a problem hiding this comment.
I think this scenario should be in separate feature, it is not about the management itself. Actor should be Visitor for this scenario too. Wdyt?
There was a problem hiding this comment.
Good point, will change! :)
pamil
force-pushed
the
theme-bundle-integration
branch
14 times, most recently
from
09259c9
to
db0ce9d
Compare
| $channel = $this->channelContext->getChannel(); | ||
|
|
||
| $themeName = $channel->getThemeName(); | ||
| return $themeName; |
There was a problem hiding this comment.
No need for that early return here.
There was a problem hiding this comment.
True, PHPStorm messed up this during extracting.
pamil
force-pushed
the
theme-bundle-integration
branch
4 times, most recently
from
23819b7
to
8c727ad
Compare
| @@ -0,0 +1,33 @@ | |||
| @ui-themes | |||
There was a problem hiding this comment.
Should be just @theme and live inside theme folder :)
pamil
force-pushed
the
theme-bundle-integration
branch
from
83b64d3
to
8b0bb4c
Compare
pamil
force-pushed
the
theme-bundle-integration
branch
5 times, most recently
from
ea38652
to
eaaae22
Compare
pamil
force-pushed
the
theme-bundle-integration
branch
from
2163d5a
to
b282063
Compare
pamil
changed the title
| @@ -25,6 +25,9 @@ | |||
| <parameter key="sylius.behat.context.setup.zone.class">Sylius\Behat\Context\Setup\ZoneContext</parameter> | |||
| <parameter key="sylius.behat.context.setup.tax.class">Sylius\Behat\Context\Setup\TaxContext</parameter> | |||
| <parameter key="sylius.behat.context.setup.order.class">Sylius\Behat\Context\Setup\OrderContext</parameter> | |||
| <parameter key="sylius.behat.context.setup.customer.class">Sylius\Behat\Context\Setup\CustomerContext</parameter> | |||
| <parameter key="sylius.behat.context.setup.addressing.class">Sylius\Behat\Context\Setup\AddressingContext</parameter> | |||
There was a problem hiding this comment.
Are these relevant to this PR?
pjedrzejewski
pushed a commit
that referenced
this pull request
Feb 29, 2016
[Core] [Theme] Integration with Sylius platform
|
Thank you Kamil! 👍 |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[Core] [Theme] Integration with Sylius platform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Themes should be set per channel by default. Based on #4172, #4169, #4156, #4268, #4287, #4292.