Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Travis] Use Selenium downloaded by Composer #4306

Merged
merged 1 commit into from
Feb 25, 2016
Merged

[Travis] Use Selenium downloaded by Composer #4306

merged 1 commit into from
Feb 25, 2016

Conversation

pamil
Copy link
Contributor

@pamil pamil commented Feb 25, 2016

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets -
License MIT
Doc PR -

michalmarcinkowski
michalmarcinkowski reviewed Feb 25, 2016
View reviewed changes
etc/travis/prepare-javascript
curl http://selenium-release.storage.googleapis.com/2.47/selenium-server-standalone-2.47.1.jar > $SYLIUS_CACHE_DIR/selenium.jar
fi

# Downloading and configurin ChromeDriver
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

configurin?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to be laid back :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then 👍 😆

@michalmarcinkowski michalmarcinkowski added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Feb 25, 2016
pjedrzejewski pushed a commit that referenced this pull request Feb 25, 2016
Merge pull request #4306 from pamil/use-composer-selenium
6005262 
[Travis] Use Selenium downloaded by Composer
@pjedrzejewski pjedrzejewski merged commit 6005262 into Sylius:master Feb 25, 2016
@pjedrzejewski
Copy link
Member

👍

@pamil pamil deleted the use-composer-selenium branch February 25, 2016 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pamil @pjedrzejewski @michalmarcinkowski