[Admin] Tax category creation #4587
Conversation
lchrusciel
force-pushed
the
tax-category-creation
branch
11 times, most recently
from
c36e7b3
to
e48838e
Compare
|
@lchrusciel Rebase needed. |
|
on it |
lchrusciel
force-pushed
the
tax-category-creation
branch
from
e48838e
to
1693444
Compare
|
and done |
lchrusciel
force-pushed
the
tax-category-creation
branch
4 times, most recently
from
7c42404
to
e18d10b
Compare
| function it_throws_an_exception_if_the_message_on_a_page_is_not_related_to_creation(NotificationAccessorInterface $notificationAccessor) | ||
| { | ||
| $notificationAccessor->hasSuccessMessage()->willReturn(true); | ||
| $notificationAccessor->isSuccessfullyCreatedFor('tax_category')->willReturn(false); |
There was a problem hiding this comment.
Why not with ManagingTaxCategoryContext::RESOURCE_NAME ?
There was a problem hiding this comment.
I'm not sure which approach is better. I'm not convinced about using const in specs. I just prefer to write it by my self, especially, because I do not have this const when I am writing first lines of spec
There was a problem hiding this comment.
That makes the specs highly vulnerable, as changing introducing a constant should happen for a reason - to keep the code DRY. It's just the same situation as with typehinting all the collaborators or using @mixin - the refactoring in most IDEs will understand it and prevent us from unnecessary, repetitive work.
As for a non-existing constant, it's nothing unusual while writing specs, as you also don't have the SUT or methods you are using on it :)
| * @Then this tax category name should be :taxCategoryName | ||
| */ | ||
| public function thisTaxCategoryNameShouldBe($taxCategoryName) | ||
| { |
There was a problem hiding this comment.
Shouldn't we always assert that page is open before using it?
lchrusciel
force-pushed
the
tax-category-creation
branch
2 times, most recently
from
fe41e5a
to
3c3ff30
Compare
| { | ||
| use SpecifiesCode; | ||
| use NamesIt; | ||
| use DescribesItAs; |
There was a problem hiding this comment.
Let's be consistent:
- SpecifiesItsCode ❓
- NamesIt 🆗
- DescribesIt~~As~~
|
@lchrusciel nice work! 👍 |
lchrusciel
force-pushed
the
tax-category-creation
branch
from
3c3ff30
to
b4fa539
Compare
|
Perfect, thanks Łukasz! |
Based on #4573