[Admin] Rework of order, coupon and products UI #5095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pjedrzejewski
commented
May 23, 2016
pjedrzejewski
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Related tickets | - |
| License | MIT |
pjedrzejewski
added
UX
|
|
|
New admin certainly looks very pretty! 👍 One small suggestion: align all financial values consistently to the right as is the 'spreadsheet standard' for readability (as you have done with the |
pjedrzejewski
force-pushed
the
ui/clean-ups
branch
3 times, most recently
from
2aa1e43
to
26d8966
Compare
pjedrzejewski
force-pushed
the
ui/clean-ups
branch
from
26d8966
to
8cb87df
Compare
pjedrzejewski
changed the title
| @@ -0,0 +1,4 @@ | |||
| <div class="ui tab" data-tab="taxes"> | |||
| <h3 class="ui dividing header">{{ 'sylius.ui.taxes'|trans }}</h3> | |||
| {{ form_row(form.masterVariant.taxCategory) }} | |||
There was a problem hiding this comment.
This should be only displayed for simple product.
There was a problem hiding this comment.
|
Thanks! |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[Admin] Rework of order, coupon and products UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.