Allow Variant selection for Products without Options #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently a bunch of code assumes that a product only has variants if it has options, even though what really matters is whether there are variants. This PR checks for the presence of variants instead of options.
pjedrzejewski
pushed a commit
that referenced
this pull request
Nov 2, 2013
Allow Variant selection for Products without Options
|
Thanks Daniel! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Sylius assumes that a product only has variants if it has options, even though what really matters is whether there are variants. In my app I am creating variants directly without options (works great, except for the areas in this PR). This PR checks for the presence of variants instead of options.