Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variant validation and backend display for products without options. #903

Merged
merged 2 commits into from
Jan 24, 2014

Conversation

Richtermeister
Copy link
Contributor

Part of my ongoing quest to work with variants without creating options.. (started here: #510)

@pjedrzejewski
Copy link
Member

I like this, but the feature has changed so you need to remove the scenario with "There are no variants to display".

@Richtermeister
Copy link
Contributor Author

@pjedrzejewski Oh, actually didn't need that condition in the template.. Good catch, should clear now. Let's see :)

@Richtermeister
Copy link
Contributor Author

Btw, Behat is coooool.

@pjedrzejewski
Copy link
Member

Yes, I love it.

pjedrzejewski pushed a commit that referenced this pull request Jan 24, 2014
Fix variant validation and backend display for products without options.
@pjedrzejewski pjedrzejewski merged commit 6430c9b into Sylius:master Jan 24, 2014
@pjedrzejewski
Copy link
Member

Thanks Daniel! 👍

@Richtermeister Richtermeister deleted the product-without-options branch January 24, 2014 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UX Issues and PRs aimed at improving User eXperience.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants