[Admin][Order] Add order notes #5319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Arminek
commented
Jun 22, 2016
Arminek
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| License | MIT |
Arminek
changed the title
|
@Arminek There is a field |
|
@Arminek We could rename it to notes indeed. |
| <div class="ui attached segment" id="sylius-order-notes"> | ||
| {{ order.notes }} | ||
| </div> | ||
| {% endif %} |
Arminek
force-pushed
the
order-notes
branch
2 times, most recently
from
b9900bc
to
ea324af
Compare
Arminek
changed the title
Arminek
force-pushed
the
order-notes
branch
3 times, most recently
from
6318c0e
to
76aae77
Compare
| @@ -134,6 +142,7 @@ protected function getDefinedElements() | |||
| 'items_table' => '#items table', | |||
| 'product_row' => 'tbody tr:contains("%name%")', | |||
| 'order_total' => 'td:contains("Total")', | |||
| 'extra_notes' =>'#sylius_checkout_summary_notes', | |||
There was a problem hiding this comment.
Why not just notes? Add I would keep alphabetical order ;)
| @@ -43,6 +43,7 @@ public function __construct(CustomerRepositoryInterface $customerRepository, Fac | |||
|
|
|||
| /** | |||
| * @Transform :customer | |||
| * @Transform /^made by "[^"]+"$/ | |||
There was a problem hiding this comment.
This should only getCustomerByEmail and never create a customer. Add second method to this context.
| /** | ||
| * @Given there is an administrator identified by :email | ||
| */ | ||
| public function theStoreHasCustomerServiceAccountIdentifiedBy($email) |
There was a problem hiding this comment.
Please change customer service to administrator in shared storage and method name too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.