[Payment] Refactor order payment state machine #5605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GSadee
commented
Jul 26, 2016
GSadee
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Related tickets | |
| License | MIT |
GSadee
force-pushed
the
state-machine-order-payment
branch
from
ca0e0ad
to
612e6d5
Compare
pjedrzejewski
added
the
BC Break
| $paymentState = PaymentInterface::STATE_PROCESSING; | ||
| } | ||
| if (OrderInterface::STATE_CANCELLED === $order->getState()) { | ||
| $order->setPaymentState(OrderPaymentStates::STATE_CANCELLED); |
There was a problem hiding this comment.
This should be a transition of state machine. We should never ever set states through setters.
GSadee
force-pushed
the
state-machine-order-payment
branch
from
612e6d5
to
2246116
Compare
| /** | ||
| * @param FactoryInterface $stateMachineFactory | ||
| */ | ||
| public function __construct( |
GSadee
force-pushed
the
state-machine-order-payment
branch
from
2246116
to
bdf1b88
Compare
| @ui | ||
| Scenario: Checking order payment state of a cancelled order | ||
| Given I view the summary of the order "#00000022" | ||
| And I cancel this order |
There was a problem hiding this comment.
Given the order was canceled
There was a problem hiding this comment.
The Given the customer canceled this order step should be renamed to the above. The implementation is fine :)
GSadee
force-pushed
the
state-machine-order-payment
branch
from
bdf1b88
to
b94b7cc
Compare
GSadee
force-pushed
the
state-machine-order-payment
branch
from
b94b7cc
to
89e7b0e
Compare
|
|
||
| if (OrderPaymentStates::STATE_PAID === $order->getPaymentState()) { | ||
| return; | ||
| } | ||
|
|
||
| if ($order->hasPayments()) { |
There was a problem hiding this comment.
Why we need this big if? Couldn't we simply add the following code to check the amount?
if (0 === $completedPaymentTotal) {
return;
}
|
Thanks Grzesiu! Please apply all comments in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.